`;
- };
- const badges = [];
- if (info.spotify_artist_id) badges.push(_hb(SPOTIFY_LOGO_URL, 'SP', 'Spotify', `https://open.spotify.com/artist/${info.spotify_artist_id}`));
- if (info.musicbrainz_id || artist.musicbrainz_id) badges.push(_hb(MUSICBRAINZ_LOGO_URL, 'MB', 'MusicBrainz', `https://musicbrainz.org/artist/${info.musicbrainz_id || artist.musicbrainz_id}`));
- if (info.deezer_id) badges.push(_hb(DEEZER_LOGO_URL, 'Dz', 'Deezer', `https://www.deezer.com/artist/${info.deezer_id}`));
- if (info.itunes_artist_id) badges.push(_hb(ITUNES_LOGO_URL, 'IT', 'Apple Music', `https://music.apple.com/artist/${info.itunes_artist_id}`));
- if (info.lastfm_url) badges.push(_hb(LASTFM_LOGO_URL, 'LFM', 'Last.fm', info.lastfm_url));
- if (info.genius_url) badges.push(_hb(GENIUS_LOGO_URL, 'GEN', 'Genius', info.genius_url));
- if (info.tidal_id) badges.push(_hb(TIDAL_LOGO_URL, 'TD', 'Tidal', `https://tidal.com/browse/artist/${info.tidal_id}`));
- if (info.qobuz_id) badges.push(_hb(QOBUZ_LOGO_URL, 'Qz', 'Qobuz', `https://www.qobuz.com/artist/${info.qobuz_id}`));
- if (info.discogs_id) badges.push(_hb(DISCOGS_LOGO_URL, 'DC', 'Discogs', `https://www.discogs.com/artist/${info.discogs_id}`));
- badgesEl.innerHTML = badges.join('');
- }
-
- // Genres (pill tags — merge with Last.fm tags, deduplicated)
- const genresEl = document.getElementById('artists-hero-genres');
- if (genresEl) {
- let genres = info.genres || artist.genres || [];
- // Merge Last.fm tags
- const lfmTags = info.lastfm_tags || [];
- if (Array.isArray(lfmTags) && lfmTags.length > 0) {
- const existing = new Set(genres.map(g => g.toLowerCase()));
- const newTags = lfmTags.filter(t => !existing.has(t.toLowerCase()));
- genres = [...genres, ...newTags];
- }
- if (genres.length > 0) {
- genresEl.innerHTML = genres.slice(0, 8).map(g =>
- `${_esc(g)}`
- ).join('');
- } else {
- genresEl.innerHTML = '';
- }
- }
-
- // Bio (Last.fm bio or summary fallback — matching library page pattern)
- const bioEl = document.getElementById('artists-hero-bio');
- if (bioEl) {
- const bio = info.lastfm_bio || info.bio || '';
- if (bio) {
- // Strip HTML tags and "Read more on Last.fm" links
- let cleanBio = bio.replace(/]*>.*?<\/a>/gi, '').replace(/<[^>]+>/g, '').trim();
- if (cleanBio) {
- bioEl.innerHTML = `${_esc(cleanBio)}
- Read more`;
- bioEl.style.display = '';
- } else {
- bioEl.style.display = 'none';
- }
- } else {
- bioEl.style.display = 'none';
- }
- }
-
- // Stats (Last.fm listeners + playcount, with followers fallback)
- const statsEl = document.getElementById('artists-hero-stats');
- if (statsEl) {
- const _fmtNum = (n) => {
- if (!n || n <= 0) return '0';
- if (n >= 1000000) return (n / 1000000).toFixed(1).replace(/\.0$/, '') + 'M';
- if (n >= 1000) return (n / 1000).toFixed(1).replace(/\.0$/, '') + 'K';
- return n.toLocaleString();
- };
- let stats = '';
- if (info.lastfm_listeners) {
- stats += `${_fmtNum(info.lastfm_listeners)} listeners`;
- }
- if (info.lastfm_playcount) {
- stats += `${_fmtNum(info.lastfm_playcount)} plays`;
- }
- if (!stats && info.followers) {
- stats += `${_fmtNum(info.followers)} followers`;
- }
- statsEl.innerHTML = stats;
- }
-
- // Also update old hidden elements for any JS that references them
- const oldImage = document.getElementById('search-artist-detail-image');
- if (oldImage && imageUrl) oldImage.style.backgroundImage = `url('${imageUrl}')`;
- const oldName = document.getElementById('search-artist-detail-name');
- if (oldName) oldName.textContent = artist.name;
-
- // Initialize watchlist button
- initializeArtistDetailWatchlistButton(artist);
-}
-
-/**
- * Initialize watchlist button for artist detail page
- */
-async function initializeArtistDetailWatchlistButton(artist) {
- const button = document.getElementById('artist-detail-watchlist-btn');
- if (!button) return;
-
- console.log(`🔧 Initializing watchlist button for artist: ${artist.name} (${artist.id})`);
-
- // Store artist info on the button for settings gear access
- button.dataset.artistId = artist.id;
- button.dataset.artistName = artist.name;
-
- // Reset button state completely
- button.disabled = false;
- button.classList.remove('watching');
- button.style.background = '';
- button.style.cursor = '';
-
- // Remove any existing click handlers to prevent duplicates
- button.onclick = null;
-
- // Set up new click handler
- button.onclick = (event) => toggleArtistDetailWatchlist(event, artist.id, artist.name);
-
- // Check and update current status
- await updateArtistDetailWatchlistButton(artist.id, artist.name);
-}
-
-/**
- * Toggle watchlist status for artist detail page
- */
-async function toggleArtistDetailWatchlist(event, artistId, artistName) {
- event.preventDefault();
-
- const button = document.getElementById('artist-detail-watchlist-btn');
- const icon = button.querySelector('.watchlist-icon');
- const text = button.querySelector('.watchlist-text');
-
- // Show loading state
- const originalText = text.textContent;
- text.textContent = 'Loading...';
- button.disabled = true;
-
- try {
- // Check current status
- const checkResponse = await fetch('/api/watchlist/check', {
- method: 'POST',
- headers: { 'Content-Type': 'application/json' },
- body: JSON.stringify({ artist_id: artistId })
- });
-
- const checkData = await checkResponse.json();
- if (!checkData.success) {
- throw new Error(checkData.error || 'Failed to check watchlist status');
- }
-
- const isWatching = checkData.is_watching;
-
- // Toggle watchlist status
- const endpoint = isWatching ? '/api/watchlist/remove' : '/api/watchlist/add';
- const payload = isWatching ?
- { artist_id: artistId } :
- { artist_id: artistId, artist_name: artistName };
-
- const response = await fetch(endpoint, {
- method: 'POST',
- headers: { 'Content-Type': 'application/json' },
- body: JSON.stringify(payload)
- });
-
- const data = await response.json();
- if (!data.success) {
- throw new Error(data.error || 'Failed to update watchlist');
- }
-
- // Update button appearance
- if (isWatching) {
- // Was watching, now removed
- icon.textContent = '👁️';
- text.textContent = 'Add to Watchlist';
- button.classList.remove('watching');
- console.log(`❌ Removed ${artistName} from watchlist`);
- } else {
- // Was not watching, now added
- icon.textContent = '👁️';
- text.textContent = 'Remove from Watchlist';
- button.classList.add('watching');
- console.log(`✅ Added ${artistName} to watchlist`);
- }
-
- // Show/hide watchlist settings gear
- const settingsBtn = document.getElementById('artist-detail-watchlist-settings-btn');
- if (settingsBtn) {
- if (!isWatching) {
- // Just added to watchlist — show gear
- settingsBtn.classList.remove('hidden');
- settingsBtn.onclick = () => openWatchlistArtistConfigModal(artistId, artistName);
- } else {
- // Just removed from watchlist — hide gear
- settingsBtn.classList.add('hidden');
- settingsBtn.onclick = null;
- }
- }
-
- // Update dashboard watchlist count
- updateWatchlistButtonCount();
-
- // Update any visible artist cards
- updateArtistCardWatchlistStatus();
-
- } catch (error) {
- console.error('Error toggling watchlist:', error);
- text.textContent = originalText;
-
- // Show error feedback
- const originalBackground = button.style.background;
- button.style.background = 'rgba(255, 59, 48, 0.3)';
- setTimeout(() => {
- button.style.background = originalBackground;
- }, 2000);
- } finally {
- button.disabled = false;
- }
-}
-
-/**
- * Update artist detail watchlist button status
- */
-async function updateArtistDetailWatchlistButton(artistId, artistName) {
- const button = document.getElementById('artist-detail-watchlist-btn');
- if (!button) {
- console.warn('⚠️ Artist detail watchlist button not found');
- return;
- }
-
- // Use passed name or fall back to stored data attribute
- const name = artistName || button.dataset.artistName || '';
-
- try {
- console.log(`🔍 Checking watchlist status for artist: ${artistId}`);
-
- const response = await fetch('/api/watchlist/check', {
- method: 'POST',
- headers: { 'Content-Type': 'application/json' },
- body: JSON.stringify({ artist_id: artistId })
- });
-
- const data = await response.json();
- if (data.success) {
- const icon = button.querySelector('.watchlist-icon');
- const text = button.querySelector('.watchlist-text');
-
- console.log(`📊 Watchlist status for ${artistId}: ${data.is_watching ? 'WATCHING' : 'NOT WATCHING'}`);
-
- // Ensure button is enabled
- button.disabled = false;
-
- // Show/hide watchlist settings gear
- const settingsBtn = document.getElementById('artist-detail-watchlist-settings-btn');
- if (settingsBtn) {
- if (data.is_watching) {
- settingsBtn.classList.remove('hidden');
- settingsBtn.onclick = () => openWatchlistArtistConfigModal(artistId, name);
- } else {
- settingsBtn.classList.add('hidden');
- settingsBtn.onclick = null;
- }
- }
-
- if (data.is_watching) {
- icon.textContent = '👁️';
- text.textContent = 'Remove from Watchlist';
- button.classList.add('watching');
- } else {
- icon.textContent = '👁️';
- text.textContent = 'Add to Watchlist';
- button.classList.remove('watching');
- }
- } else {
- console.error('❌ Failed to check watchlist status:', data.error);
- }
- } catch (error) {
- console.error('❌ Error checking watchlist status:', error);
- // Ensure button doesn't get stuck in bad state
- button.disabled = false;
- }
-}
-
-/**
- * Show loading state for discography
- */
-function showDiscographyLoading() {
- const albumsContainer = document.getElementById('album-cards-container');
- const singlesContainer = document.getElementById('singles-cards-container');
-
- const loadingHtml = `
-
-
-
-
Loading...
-
-
-
-
-
-
- `.repeat(4);
-
- if (albumsContainer) albumsContainer.innerHTML = loadingHtml;
- if (singlesContainer) singlesContainer.innerHTML = loadingHtml;
-}
-
-/**
- * Show error state for discography
- */
-function showDiscographyError(message = 'Failed to load discography') {
- const albumsContainer = document.getElementById('album-cards-container');
- const singlesContainer = document.getElementById('singles-cards-container');
-
- const errorHtml = `
-
-
⚠️
-
Failed to load discography
-
${escapeHtml(message)}
-
- `;
-
- if (albumsContainer) albumsContainer.innerHTML = errorHtml;
- if (singlesContainer) singlesContainer.innerHTML = errorHtml;
-}
-
-/**
- * Show loading cards while searching
- */
-function showSearchLoadingCards() {
- const container = document.getElementById('artists-cards-container');
- if (!container) return;
-
- const loadingCardHtml = `
-
-
-
-
-
Loading...
-
Fetching data...
-
- ⏳
- Loading...
-
-
-
- `;
-
- // Show 6 loading cards
- container.innerHTML = loadingCardHtml.repeat(6);
-}
-
-// ===============================
-// ARTIST ALBUM DOWNLOAD MISSING TRACKS INTEGRATION
-// ===============================
-
-/**
- * Get the completion status of an album from cached data or DOM
- * @param {string} albumId - The album ID
- * @param {string} albumType - The album type ('albums' or 'singles')
- * @returns {Object|null} - Completion status object or null
- */
-function getAlbumCompletionStatus(albumId, albumType) {
- try {
- // First, check cached completion data
- const artistId = artistsPageState.selectedArtist?.id;
- if (artistId && artistsPageState.cache.completionData[artistId]) {
- const cachedData = artistsPageState.cache.completionData[artistId];
- const dataArray = albumType === 'albums' ? cachedData.albums : cachedData.singles;
-
- if (dataArray) {
- const completionData = dataArray.find(item => item.album_id === albumId || item.id === albumId);
- if (completionData) {
- console.log(`📊 Found cached completion data for album ${albumId}:`, completionData);
- return completionData;
- }
- }
- }
-
- // Fallback: Check DOM completion overlay
- const containerId = albumType === 'albums' ? 'album-cards-container' : 'singles-cards-container';
- const container = document.getElementById(containerId);
-
- if (container) {
- const albumCard = container.querySelector(`[data-album-id="${albumId}"]`);
- if (albumCard) {
- const overlay = albumCard.querySelector('.completion-overlay');
- if (overlay) {
- // Extract status from overlay classes
- const classList = Array.from(overlay.classList);
- const statusClasses = ['completed', 'nearly_complete', 'partial', 'missing', 'downloading', 'downloaded', 'error'];
- const status = statusClasses.find(cls => classList.includes(cls));
-
- if (status) {
- console.log(`📊 Found DOM completion status for album ${albumId}: ${status}`);
- return { status, completion_percentage: status === 'completed' ? 100 : 0 };
- }
- }
- }
- }
-
- console.warn(`⚠️ No completion status found for album ${albumId}`);
- return null;
-
- } catch (error) {
- console.error(`❌ Error getting album completion status for ${albumId}:`, error);
- return null;
- }
-}
-
-/**
- * Handle album/single/EP click to open download missing tracks modal
- */
-async function handleArtistAlbumClick(album, albumType) {
- console.log(`🎵 Album clicked: ${album.name} (${album.album_type}) from artist: ${artistsPageState.selectedArtist?.name}`);
-
- if (!artistsPageState.selectedArtist) {
- console.error('❌ No selected artist found');
- showToast('Error: No artist selected', 'error');
- return;
- }
-
- showLoadingOverlay('Loading album...');
-
- try {
- // Check completion status of the album
- const completionStatus = getAlbumCompletionStatus(album.id, albumType);
- console.log(`📊 Album completion status: ${completionStatus?.status || 'unknown'} (${completionStatus?.completion_percentage || 0}%)`);
-
- // For Artists page, always use Download Missing Tracks modal to analyze and download
- console.log(`🔄 Opening download missing tracks modal for album analysis`);
-
- // Create virtual playlist ID
- const virtualPlaylistId = `artist_album_${artistsPageState.selectedArtist.id}_${album.id}`;
-
- // Check if modal already exists and show it
- if (activeDownloadProcesses[virtualPlaylistId]) {
- console.log(`📱 Reopening existing modal for ${album.name}`);
- const process = activeDownloadProcesses[virtualPlaylistId];
- if (process.modalElement) {
- if (process.status === 'complete') {
- showToast('Showing previous results. Close this modal to start a new analysis.', 'info');
- }
- process.modalElement.style.display = 'flex';
- hideLoadingOverlay();
- return;
- }
- }
-
- // Create virtual playlist and open modal
- // Note: Don't hide loading overlay here - let the flow continue through to the modal
- await createArtistAlbumVirtualPlaylist(album, albumType);
-
- } catch (error) {
- hideLoadingOverlay();
- console.error('❌ Error handling album click:', error);
- showToast(`Error opening download modal: ${error.message}`, 'error');
- }
-}
-
-/**
- * Create virtual playlist for artist album and open download missing tracks modal
- */
-async function createArtistAlbumVirtualPlaylist(album, albumType) {
- const artist = artistsPageState.selectedArtist;
- const virtualPlaylistId = `artist_album_${artist.id}_${album.id}`;
-
- console.log(`🎵 Creating virtual playlist for: ${artist.name} - ${album.name}`);
-
- try {
- // Loading overlay already shown by handleArtistAlbumClick
-
- // Fetch album tracks from backend (pass name/artist for Hydrabase support)
- const _aat1 = new URLSearchParams({ name: album.name || '', artist: artist.name || '' });
- const albumSource = artistsPageState.sourceOverride || album.source || artist.source || artistsPageState.artistDiscography?.source || null;
- if (albumSource) {
- _aat1.set('source', albumSource);
- }
- if (artistsPageState.pluginOverride) {
- _aat1.set('plugin', artistsPageState.pluginOverride);
- }
- const response = await fetch(`/api/album/${album.id}/tracks?${_aat1}`);
-
- if (!response.ok) {
- if (response.status === 401) {
- throw new Error('Spotify not authenticated. Please check your API settings.');
- }
- const errData = await response.json().catch(() => ({}));
- throw new Error(errData.error || `Failed to load album tracks: ${response.status}`);
- }
-
- const data = await response.json();
-
- if (!data.success || !data.tracks || data.tracks.length === 0) {
- throw new Error('No tracks found for this album');
- }
-
- console.log(`✅ Loaded ${data.tracks.length} tracks for ${data.album.name}`);
-
- // Use album data from API response (has complete data including images array)
- const fullAlbumData = data.album;
-
- // Format playlist name with artist and album info
- const playlistName = `[${artist.name}] ${fullAlbumData.name}`;
-
- // Open download missing tracks modal with formatted tracks
- // Pass false for showLoadingOverlay since we already have one from handleArtistAlbumClick
- // Use fullAlbumData from API response instead of album parameter
- await openDownloadMissingModalForArtistAlbum(virtualPlaylistId, playlistName, data.tracks, fullAlbumData, artist, false);
-
- // Track this download for artist bubble management
- registerArtistDownload(artist, album, virtualPlaylistId, albumType);
-
- } catch (error) {
- console.error('❌ Error creating virtual playlist:', error);
- showToast(`Failed to load album: ${error.message}`, 'error');
- throw error;
- }
-}
-
-/**
- * Open download missing tracks modal specifically for artist albums
- * Similar to openDownloadMissingModalForYouTube but for artist albums
- */
diff --git a/webui/static/helper.js b/webui/static/helper.js
index bafe250c..dcbb56af 100644
--- a/webui/static/helper.js
+++ b/webui/static/helper.js
@@ -3546,21 +3546,18 @@ function closeHelperSearch() {
// WHAT'S NEW (Phase 6)
// ═══════════════════════════════════════════════════════════════════════════
-// Entries tagged with `unreleased: true` are accumulating under a version label
-// but won't display until the build version catches up. The Search/Artists
-// unification project stays folded here at 2.40 until the whole thing ships.
const WHATS_NEW = {
'2.40': [
- // --- Search & Artists unification (in progress, not yet released) ---
- { date: 'Unreleased — Search & Artists unification', unreleased: true },
- { title: 'Search Source Picker', desc: 'The Search page\'s Enhanced/Basic toggle is replaced by a single "Search from" dropdown at the top — pick All sources (Auto), Spotify, Apple Music, Deezer, Discogs, Hydrabase, MusicBrainz, or Soulseek (raw files). Auto keeps today\'s multi-source fan-out; picking a specific source hits only that provider so there are no more surprise Spotify rate-limit hits from flows that didn\'t need Spotify. "Soulseek" routes to the raw-file search (what "Basic" used to do), so one picker now covers both old modes. Loading text reflects the selected source', page: 'search', unreleased: true },
- { title: 'Explicit Source Selection on /api/enhanced-search', desc: 'The enhanced-search endpoint now accepts an optional `source` body param (spotify, itunes, deezer, discogs, hydrabase, musicbrainz, auto). When a specific source is chosen, only that provider is queried and db_artists (local library matches) still come back. Cache keys isolate per-source so single-source and multi-source results don\'t collide. Omitted or `auto` preserves the old multi-source fan-out behavior unchanged — nothing breaks for existing callers', page: 'search', unreleased: true },
- { title: 'Shared Enhanced-Search Fetch Helper', desc: 'Internal refactor — the Search page dropdown and the global search widget now route through one shared enhancedSearchFetch helper in search.js instead of duplicating the POST boilerplate. Zero UX change, but it means any future source-picker tweak only needs wiring in one place', page: 'search', unreleased: true },
- { title: 'Search Page Renamed to /search', desc: 'The Search page\'s internal id is now "search" instead of the confusing "downloads" (which clashed with the actual Downloads page). Sidebar label unchanged. URL is now /search; /downloads still resolves so old bookmarks keep working. Profile ACL "Page Access" now saves as "search"; existing profiles with "downloads" in allowed_pages still resolve through a legacy-compat check', page: 'search', unreleased: true },
- { title: 'Embedded Download Manager Removed from Search Page', desc: 'The Search page used to carry a second copy of the Download Manager (active + finished queues, clear/cancel-all buttons) that was hidden by default and duplicated the dedicated Downloads page. That duplicate is gone — toggle button, side-panel HTML, and its 1-second polling loop all removed. About 330 lines of dead code cleaned up. The dedicated Downloads sidebar page is now the single downloads UI', page: 'search', unreleased: true },
- { title: 'Artists Sidebar Entry Retired — Use Search Instead', desc: 'Cin flagged that "Artists" in the sidebar read like a library section but was actually a dedicated artist-search page, duplicating what the unified Search already does. The sidebar entry is gone. New flow: Sidebar → Search → type artist name → click their result. "Browse Artists" on the empty Watchlist page and "View artist from Wishlist" now open Search pre-filled with the artist\'s name. Removed "Artists" from profile Home Page + Page Access options. Deep link to /artists still resolves so old bookmarks keep working — the page just isn\'t promoted anywhere', page: 'search', unreleased: true },
- { title: 'Artist Detail Back Button Fallback', desc: 'The back button on the Artists-page inline detail view used to dump users on an empty "Search for an artist..." screen when they arrived from outside the Artists page — a dead end now that Artists isn\'t in the sidebar. If you searched inside the Artists page, back still returns to your results list. Otherwise (arriving from Search, Discover, Watchlist, etc.), back uses the browser history to land you on whichever page you came from. Falls back to the Search page only when there\'s no browser history to go back to (the natural place to find another artist)', page: 'search', unreleased: true },
- { title: 'Interactive Help Updated for Unified Search', desc: 'The click-for-help annotations and the "Your First Download" guided tour were rewritten for the new Search page. Stale annotations pointing at removed elements (Basic/Enhanced toggle button, side-panel queues, download-manager controls) are deleted. The first-download tour now runs on /search and opens with the source picker. PAGE_TOUR_MAP accepts both "search" and the legacy "downloads" id so old bookmarks still match a tour. Retired the standalone "Browse Artists" tour', page: 'help', unreleased: true },
+ // --- April 24, 2026 — Search & Artists unification ---
+ { date: 'April 24, 2026 — Search & Artists unification' },
+ { title: 'Unified Artist Detail Page', desc: 'Clicking any artist anywhere — Search results, Discover, Watchlist, Stats, Library, API monitor, Wishlist, Media player — now lands on the same standalone /artist-detail page. Before, library artists and metadata-source artists went to two different pages (one inline, one standalone). The backend /api/artist-detail endpoint now accepts an optional ?source= param and falls back to a metadata-source lookup when the local DB lookup misses, so Deezer/Spotify/iTunes/Discogs/Hydrabase/MusicBrainz artists work on the same page as library artists. Stable deep-link URL; source context carried through cleanly', page: 'library' },
+ { title: 'Artists Page Retired — artists.js Deleted', desc: 'The Artists sidebar entry was already retired earlier; this release finishes the job by deleting the inline page itself (4600-line file, 140 HTML lines). Shared helpers the rest of the app depended on (escapeHtml used 229 times, service-status polling, image-colour extraction, download-bubble infrastructure, discography completion checking, enrichment card rendering) were extracted into a new webui/static/shared-helpers.js so other modules keep working. Legacy /artists URL now aliases to /search for bookmark compatibility', page: 'library' },
+ { title: 'Search Source Picker', desc: 'The Search page\'s Enhanced/Basic toggle is replaced by a single "Search from" dropdown at the top — pick All sources (Auto), Spotify, Apple Music, Deezer, Discogs, Hydrabase, MusicBrainz, or Soulseek (raw files). Auto keeps today\'s multi-source fan-out; picking a specific source hits only that provider so there are no more surprise Spotify rate-limit hits from flows that didn\'t need Spotify. "Soulseek" routes to the raw-file search (what "Basic" used to do), so one picker now covers both old modes. Loading text reflects the selected source', page: 'search' },
+ { title: 'Explicit Source Selection on /api/enhanced-search', desc: 'The enhanced-search endpoint now accepts an optional `source` body param (spotify, itunes, deezer, discogs, hydrabase, musicbrainz, auto). When a specific source is chosen, only that provider is queried and db_artists (local library matches) still come back. Cache keys isolate per-source so single-source and multi-source results don\'t collide. Omitted or `auto` preserves the old multi-source fan-out behavior unchanged — nothing breaks for existing callers', page: 'search' },
+ { title: 'Shared Enhanced-Search Fetch Helper', desc: 'Internal refactor — the Search page dropdown and the global search widget now route through one shared enhancedSearchFetch helper in search.js instead of duplicating the POST boilerplate. Zero UX change, but it means any future source-picker tweak only needs wiring in one place', page: 'search' },
+ { title: 'Search Page Renamed to /search', desc: 'The Search page\'s internal id is now "search" instead of the confusing "downloads" (which clashed with the actual Downloads page). Sidebar label unchanged. URL is now /search; /downloads still resolves so old bookmarks keep working. Profile ACL "Page Access" now saves as "search"; existing profiles with "downloads" in allowed_pages still resolve through a legacy-compat check', page: 'search' },
+ { title: 'Embedded Download Manager Removed from Search Page', desc: 'The Search page used to carry a second copy of the Download Manager (active + finished queues, clear/cancel-all buttons) that was hidden by default and duplicated the dedicated Downloads page. That duplicate is gone — toggle button, side-panel HTML, and its 1-second polling loop all removed. About 330 lines of dead code cleaned up. The dedicated Downloads sidebar page is now the single downloads UI', page: 'search' },
+ { title: 'Interactive Help Updated for Unified Search', desc: 'The click-for-help annotations and the "Your First Download" guided tour were rewritten for the new Search page. Stale annotations pointing at removed elements (Basic/Enhanced toggle button, side-panel queues, download-manager controls) are deleted. The first-download tour now runs on /search and opens with the source picker. PAGE_TOUR_MAP accepts both "search" and the legacy "downloads" id so old bookmarks still match a tour. Retired the standalone "Browse Artists" tour', page: 'help' },
],
'2.39': [
// --- April 22, 2026 ---
@@ -3765,13 +3762,7 @@ function _getCurrentVersion() {
}
function _getLatestWhatsNewVersion() {
- // Only surface entries whose version number is <= the current build. Entries
- // sitting at higher versions are unreleased work-in-progress and shouldn't
- // flag as "new" in the helper badge until the build catches up.
- const buildVer = parseFloat(_getCurrentVersion()) || 2.39;
- const versions = Object.keys(WHATS_NEW)
- .filter(v => (parseFloat(v) || 0) <= buildVer)
- .sort((a, b) => parseFloat(b) - parseFloat(a));
+ const versions = Object.keys(WHATS_NEW).sort((a, b) => parseFloat(b) - parseFloat(a));
return versions[0] || '2.39';
}
@@ -3860,11 +3851,8 @@ function _openFullChangelog() {
}
function _showOlderNotes() {
- // Cycle to next older version in the what's new panel (skip unreleased entries)
- const buildVer = parseFloat(_getCurrentVersion()) || 2.39;
- const versions = Object.keys(WHATS_NEW)
- .filter(v => (parseFloat(v) || 0) <= buildVer)
- .sort((a, b) => parseFloat(b) - parseFloat(a));
+ // Cycle to next older version in the what's new panel
+ const versions = Object.keys(WHATS_NEW).sort((a, b) => parseFloat(b) - parseFloat(a));
const panel = _helperPopover;
if (!panel) return;
const currentTitle = panel.querySelector('.helper-popover-title');
diff --git a/webui/static/init.js b/webui/static/init.js
index e8e38463..2c28c897 100644
--- a/webui/static/init.js
+++ b/webui/static/init.js
@@ -2010,7 +2010,7 @@ function _getPageFromPath() {
const basePage = path.split('/')[0];
if (!_DEEPLINK_VALID_PAGES.has(basePage)) return 'dashboard';
// Context-dependent pages fall back to a sensible parent
- if (basePage === 'artist-detail') return 'artists';
+ if (basePage === 'artist-detail') return 'library';
if (basePage === 'playlist-explorer') return 'library';
return basePage;
}
@@ -2115,8 +2115,10 @@ function initializeWatchlist() {
}
function navigateToPage(pageId, options = {}) {
- // Backwards-compat alias — the Search page used to live under id 'downloads'.
- if (pageId === 'downloads') pageId = 'search';
+ // Backwards-compat aliases — the Search page used to live under id
+ // 'downloads', and the Artists page was retired and folded into Search.
+ // Legacy bookmarks to /downloads or /artists all land on /search.
+ if (pageId === 'downloads' || pageId === 'artists') pageId = 'search';
if (pageId === currentPage) return;
@@ -2218,15 +2220,7 @@ async function loadPageData(pageId) {
initializeSearchModeToggle();
initializeFilters();
break;
- case 'artists':
- // Only fully initialize if not already initialized
- if (!artistsPageState.isInitialized) {
- initializeArtistsPage();
- } else {
- // Just restore state if already initialized
- restoreArtistsPageState();
- }
- break;
+ // 'artists' page retired — aliased to 'search' at the top of navigateToPage
case 'active-downloads':
loadActiveDownloadsPage();
break;
diff --git a/webui/static/shared-helpers.js b/webui/static/shared-helpers.js
index d45737f5..66320cea 100644
--- a/webui/static/shared-helpers.js
+++ b/webui/static/shared-helpers.js
@@ -2759,3 +2759,79 @@ function renderEnrichmentCards(enrichment) {
}
// ===============================
+
+
+// ----------------------------------------------------------------------------
+// Additional helpers from the retired Artists page still needed by other files
+// ----------------------------------------------------------------------------
+
+async function lazyLoadArtistImages(container) {
+ if (!container) {
+ console.error('❌ lazyLoadArtistImages: container is null');
+ return;
+ }
+
+ const cardsNeedingImages = container.querySelectorAll('[data-needs-image="true"]');
+
+ if (cardsNeedingImages.length === 0) {
+ console.log('✅ All artist cards have images');
+ return;
+ }
+
+ console.log(`🖼️ Lazy loading images for ${cardsNeedingImages.length} artist cards`);
+
+ const batchSize = 5;
+ const cards = Array.from(cardsNeedingImages);
+
+ for (let i = 0; i < cards.length; i += batchSize) {
+ const batch = cards.slice(i, i + batchSize);
+
+ await Promise.all(batch.map(async (card) => {
+ const artistId = card.dataset.artistId;
+ if (!artistId) {
+ console.warn('⚠️ Card missing artistId:', card);
+ return;
+ }
+
+ try {
+ const response = await fetch(`/api/artist/${artistId}/image`);
+ const data = await response.json();
+
+ if (data.success && data.image_url) {
+ if (card.classList.contains('suggestion-card')) {
+ card.style.backgroundImage = `url(${data.image_url})`;
+ card.style.backgroundSize = 'cover';
+ card.style.backgroundPosition = 'center';
+ } else if (card.classList.contains('artist-card')) {
+ const bgElement = card.querySelector('.artist-card-background');
+ if (bgElement) {
+ bgElement.style.cssText = `background-image: url('${data.image_url}'); background-size: cover; background-position: center;`;
+ }
+ }
+
+ card.dataset.needsImage = 'false';
+ }
+ } catch (error) {
+ console.error(`❌ Failed to load image for artist ${artistId}:`, error);
+ }
+ }));
+ }
+}
+
+// Legacy global alias — wishlist-tools.js falls back to window.lazyLoadArtistImages
+window.lazyLoadArtistImages = lazyLoadArtistImages;
+
+
+// ----------------------------------------------------------------------------
+// Completion error overlay — called from checkDiscographyCompletion above
+// ----------------------------------------------------------------------------
+
+function showCompletionError() {
+ const allOverlays = document.querySelectorAll('.completion-overlay.checking');
+ allOverlays.forEach(overlay => {
+ overlay.classList.remove('checking');
+ overlay.classList.add('error');
+ overlay.innerHTML = 'Error';
+ overlay.title = 'Failed to check completion status';
+ });
+}