From 455945e6cb50a71f4fd2702be7b5a47bdcf5292d Mon Sep 17 00:00:00 2001
From: Broque Thomas <26755000+Nezreka@users.noreply.github.com>
Date: Sun, 5 Apr 2026 18:48:03 -0700
Subject: [PATCH] Fix duplicate detector missing cross-album duplicates (#252)

Changed ignore_cross_album default from True to False. Re-downloads of
the same song create separate album entries, so the detector was skipping
them. Users who want to keep compilations/greatest-hits intact can toggle
it back on. Updated help text to explain when to use this setting.
---
 core/repair_jobs/duplicate_detector.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/core/repair_jobs/duplicate_detector.py b/core/repair_jobs/duplicate_detector.py
index 5588c642..e67e0d47 100644
--- a/core/repair_jobs/duplicate_detector.py
+++ b/core/repair_jobs/duplicate_detector.py
@@ -25,8 +25,9 @@ class DuplicateDetectorJob(RepairJob):
         'Settings:\n'
         '- Title Similarity: How closely titles must match to be considered duplicates (0.0 - 1.0)\n'
         '- Artist Similarity: How closely artist names must match (0.0 - 1.0)\n'
-        '- Ignore Cross-Album: When enabled, tracks on different albums are not flagged as duplicates '
-        '(keeps your albums complete even if the same song appears on multiple albums)'
+        '- Ignore Cross-Album: When enabled, tracks on different albums are not flagged as duplicates. '
+        'Turn this OFF if you have duplicate downloads filed under different album entries — '
+        'this is the most common cause of missed duplicates from re-downloads'
     )
     icon = 'repair-icon-duplicate'
     default_enabled = False
@@ -34,7 +35,7 @@ class DuplicateDetectorJob(RepairJob):
     default_settings = {
         'title_similarity': 0.85,
         'artist_similarity': 0.80,
-        'ignore_cross_album': True,
+        'ignore_cross_album': False,
     }
     auto_fix = False