Feature/clean up legacy demo user id property (#4808)

* Clean up

apps/api/src/app/info/info.service.ts

@@ -11,7 +11,7 @@ import {
   HEADER_KEY_TOKEN,
   PROPERTY_BETTER_UPTIME_MONITOR_ID,
   PROPERTY_COUNTRIES_OF_SUBSCRIBERS,
-  PROPERTY_DEMO_USER_ID_LEGACY,
+  PROPERTY_DEMO_USER_ID,
   PROPERTY_IS_READ_ONLY_MODE,
   PROPERTY_SLACK_COMMUNITY_USERS,
   ghostfolioFearAndGreedIndexDataSource
@@ -237,7 +237,7 @@ export class InfoService {
 
   private async getDemoAuthToken() {
     const demoUserId = (await this.propertyService.getByKey(
-      PROPERTY_DEMO_USER_ID_LEGACY
+      PROPERTY_DEMO_USER_ID
     )) as string;
 
     if (demoUserId) {

libs/common/src/lib/config.ts

@@ -122,7 +122,6 @@ export const PROPERTY_DATA_SOURCES_GHOSTFOLIO_DATA_PROVIDER_MAX_REQUESTS =
   'DATA_SOURCES_GHOSTFOLIO_DATA_PROVIDER_MAX_REQUESTS';
 export const PROPERTY_DEMO_ACCOUNT_ID = 'DEMO_ACCOUNT_ID';
 export const PROPERTY_DEMO_USER_ID = 'DEMO_USER_ID';
-export const PROPERTY_DEMO_USER_ID_LEGACY = 'DEMO_USER_ID_LEGACY';
 export const PROPERTY_IS_DATA_GATHERING_ENABLED = 'IS_DATA_GATHERING_ENABLED';
 export const PROPERTY_IS_READ_ONLY_MODE = 'IS_READ_ONLY_MODE';
 export const PROPERTY_IS_USER_SIGNUP_ENABLED = 'IS_USER_SIGNUP_ENABLED';